Actually fix image diff padding/border #12381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-gitea#12346 was using the wrong selector which affected only the single image view. Use the correct selector for image diffs. Removal of border-radius is still worth to keep to override the global 3px on <img>.
zeripath
approved these changes
Jul 30, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
type/bug
topic/ui
|
Bump |
lafriks
approved these changes
Aug 6, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12346 was using the wrong selector which affected only the single image view. Use the correct selector for image diffs. Removal of border-radius is still worth to keep to override the global 3px on
<img>.