Extend Notifications API and return pinned notifications by default #12164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions list Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
Will these changes be backported to 1.12? |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
|
Thanks @zeripath for the fixes. I hope these fixes makes it to 1.12.2. |
lafriks
approved these changes
Jul 7, 2020
GiteaBot
added
lgtm/need 1
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
requested changes
Jul 7, 2020
zeripath
commented
Jul 7, 2020
lafriks
approved these changes
Jul 7, 2020
|
CI failed. |
|
CI failure was not related to this change because this change does not affect those endpoints - certainly there were issues because of unchanged tests earlier. |
6543
reviewed
Jul 8, 2020
Signed-off-by: Andrew Thornton <[email protected]>
6543
reviewed
Jul 10, 2020
zeripath
commented
Jul 10, 2020
6543
requested changes
Jul 10, 2020
Signed-off-by: Andrew Thornton <[email protected]>
|
I'm not certain that using IN for 1 argument is actually worth it - but then again it's arguably a premature optimisation to do the len() check - so in which case I will do it. |
6543
approved these changes
Jul 11, 2020
GiteaBot
added
lgtm/done
|
🚀 |
|
should we partialy backport it to 1.12? (so that pinned ones are with the unreaded) ? |
|
I guess we can claim it is a bug. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 13, 2020
…o-gitea#12164) Backport go-gitea#12164 This PR extends the notifications API to allow specific notification statuses to be searched for and to allow setting of notifications to statuses other than read. By default unread and pinned statuses will be returned when querying for notifications - however pinned statuses will not be marked as read. Close go-gitea#12152 Signed-off-by: Andrew Thornton [email protected]
zeripath
added
backport/done
zeripath
added a commit
that referenced
this pull request
Jul 13, 2020
…12164) (#12232) Backport #12164 This PR extends the notifications API to allow specific notification statuses to be searched for and to allow setting of notifications to statuses other than read. By default unread and pinned statuses will be returned when querying for notifications - however pinned statuses will not be marked as read. Close #12152 Signed-off-by: Andrew Thornton [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the notifications API to allow specific notification statuses to be searched for and to allow setting of notifications to statuses other than read.
By default unread and pinned statuses will be returned when querying for notifications - however pinned statuses will not be marked as read.
Close #12152
Signed-off-by: Andrew Thornton [email protected]