Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with globally disabling mirror #11760

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fix bug with globally disabling mirror #11760

merged 2 commits into from
Jun 4, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 4, 2020 •
edited
Loading

just sorry - the easy once produce this kind of bugs :/

@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@zeripath zeripath changed the title Noice Fix bug with globally disabling mirror Jun 4, 2020
@6543
Copy link
Member Author

6543 commented Jun 4, 2020

ready to merge

@zeripath zeripath merged commit 2c5b3c7 into go-gitea:master Jun 4, 2020
@6543 6543 deleted the noice branch June 4, 2020 23:20
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Fix bug with globally disabling mirror (go-gitea#11760)
8fddeeb 
Ensure we return after `ctx.Error(...)`
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @techknowlogick @zeripath @GiteaBot