Don't put integration test data outside of test folder #11746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some integration test data is being put outside of the integration test folders which means it isn't deleted properly with make clean. Update config so it works as expected.
techknowlogick
approved these changes
Jun 3, 2020
GiteaBot
added
the
lgtm/need 1
guillep2k
suggested changes
Jun 3, 2020
| @@ -33,12 +33,15 @@ SSH_LISTEN_HOST = localhost | |||
| SSH_PORT = 2201 | |||
| START_SSH_SERVER = true | |||
| LFS_START_SERVER = true | |||
| LFS_CONTENT_PATH = data/lfs-mssql | |||
| LFS_CONTENT_PATH = integrations/gitea-integration-mssql/data/lfs-mssql | |||
There was a problem hiding this comment.
Suggested change
| LFS_CONTENT_PATH = integrations/gitea-integration-mssql/data/lfs-mssql | |
| LFS_CONTENT_PATH = {{REPO_TEST_DIR}}integrations/gitea-integration-mssql/data/lfs-mssql |
| OFFLINE_MODE = false | ||
| LFS_JWT_SECRET = Tv_MjmZuHqpIY6GFl12ebgkRAMt4RlWt0v4EHKSXO0w | ||
| APP_DATA_PATH = integrations/gitea-integration-mssql/data | ||
| BUILTIN_SSH_SERVER_USER = git | ||
|
|
||
| [attachment] | ||
| PATH = integrations/gitea-integration-mssql/data |
There was a problem hiding this comment.
Suggested change
| PATH = integrations/gitea-integration-mssql/data | |
| PATH = {{REPO_TEST_DIR}}integrations/gitea-integration-mssql/data |
| ENABLE_FEDERATED_AVATAR = false | ||
| DISABLE_GRAVATAR = false | ||
| ENABLE_FEDERATED_AVATAR = false | ||
| AVATAR_UPLOAD_PATH = integrations/gitea-integration-mssql/data/avatars |
There was a problem hiding this comment.
Suggested change
| AVATAR_UPLOAD_PATH = integrations/gitea-integration-mssql/data/avatars | |
| AVATAR_UPLOAD_PATH = {{REPO_TEST_DIR}}integrations/gitea-integration-mssql/data/avatars |
| DISABLE_GRAVATAR = false | ||
| ENABLE_FEDERATED_AVATAR = false | ||
| AVATAR_UPLOAD_PATH = integrations/gitea-integration-mssql/data/avatars | ||
| REPOSITORY_AVATAR_UPLOAD_PATH = integrations/gitea-integration-mssql/data/repo-avatars |
There was a problem hiding this comment.
Suggested change
| REPOSITORY_AVATAR_UPLOAD_PATH = integrations/gitea-integration-mssql/data/repo-avatars | |
| REPOSITORY_AVATAR_UPLOAD_PATH = {{REPO_TEST_DIR}}integrations/gitea-integration-mssql/data/repo-avatars |
|
@guillep2k none of the indexers, db, or anything else outside of repos themselves currently use this I don't see why this would be different. I think these should stay until somebody has run make clean same as those |
guillep2k
approved these changes
Jun 3, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Some integration test data is being put outside of the integration test folders which means it isn't deleted properly with make clean. Update config so it works as expected. Co-authored-by: John Olheiser <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some integration test data is being put outside of the integration test folders which means it isn't deleted properly with make clean. Update config so it works as expected.
Found 48GB of LFS test data and 17GB of attachments uncleaned in my data folder 😑