Make tabular menu styling consistent for arc-green #11570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe make the tab background one shade darker? It stands out a bit too much imho. |
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
May 23, 2020
|
Changed active item to be darker and updated screenshots. |
CirnoT
added a commit
to CirnoT/gitea
that referenced
this pull request
May 23, 2020
silverwind
reviewed
May 24, 2020
silverwind
approved these changes
May 24, 2020
GiteaBot
added
lgtm/need 1
Co-authored-by: silverwind <[email protected]>
techknowlogick
added a commit
that referenced
this pull request
May 25, 2020
* Style code review comment for arc-green * change border around review for light; update border around textarea to match #11570 Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>
mrsdizzie
approved these changes
May 29, 2020
GiteaBot
added
lgtm/done
|
Make lg-tm work |
|
Pleace Backport |
CirnoT
added a commit
to CirnoT/gitea
that referenced
this pull request
Jun 7, 2020
* Make tabular menu styling consistent for arc-green * rework completely * transparent borders * use darker color for active item; override only colors for borders * Update web_src/less/themes/theme-arc-green.less Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: zeripath <[email protected]> (cherry picked from commit 4395c60)
techknowlogick
pushed a commit
that referenced
this pull request
Jun 7, 2020
* Make tabular menu styling consistent for arc-green * rework completely * transparent borders * use darker color for active item; override only colors for borders * Update web_src/less/themes/theme-arc-green.less Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: zeripath <[email protected]> (cherry picked from commit 4395c60)
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Style code review comment for arc-green * change border around review for light; update border around textarea to match go-gitea#11570 Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Make tabular menu styling consistent for arc-green * rework completely * transparent borders * use darker color for active item; override only colors for borders * Update web_src/less/themes/theme-arc-green.less Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes styling of tabular menu in forms consistent across site for arc-green and in-line with how it looks on default theme.
Before:
After:
The "After" styling was partially taken from what was previously applied only to Wiki form.