Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add pull review endpoints #11224

Merged
merged 40 commits into from
May 2, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
bbdc5a0
API: Added pull review read only endpoints
tbe Jan 26, 2020
44d32f0
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 26, 2020
70dfe71
Update Structs, move Conversion, Refactor
6543 Apr 27, 2020
644aa1c
refactor
6543 Apr 27, 2020
79eca0b
lint & co
6543 Apr 27, 2020
0ce765c
fix lint + refactor
6543 Apr 27, 2020
d860be8
add new Review state, rm unessesary, refacotr loadAttributes, convert…
6543 Apr 27, 2020
a4b998c
add DeletePullReview
6543 Apr 27, 2020
582c6c0
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 27, 2020
e1c13b0
add paggination
6543 Apr 27, 2020
4b60f40
draft1: Create & submit review
6543 Apr 27, 2020
4f95b62
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 27, 2020
2f2c400
fix lint
6543 Apr 27, 2020
aeda695
fix lint
6543 Apr 27, 2020
ed15f52
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 28, 2020
63c7b4e
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 28, 2020
ef2047d
impruve test
6543 Apr 28, 2020
42a6b89
DONT use GhostUser for loadReviewer
6543 Apr 28, 2020
5a6f383
expose comments_count of a PullReview
6543 Apr 28, 2020
eedd1f2
infent GetCodeCommentsCount()
6543 Apr 28, 2020
ac86f43
fixes
6543 Apr 28, 2020
75f6c1b
fix+impruve
6543 Apr 28, 2020
efd8bb9
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 28, 2020
c7cd256
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 29, 2020
627b9d6
some nits
6543 Apr 29, 2020
0cf99dc
Handle Ghosts :ghost:
6543 Apr 29, 2020
d9e1480
add TEST for GET apis
6543 Apr 29, 2020
cbca510
complete TESTS
6543 Apr 29, 2020
9b0bbc1
add HTMLURL to PullReview responce
6543 Apr 29, 2020
ac9a31f
code format as per @lafriks
6543 Apr 29, 2020
c7722ae
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 29, 2020
28d4f34
update swagger definition
6543 Apr 29, 2020
ab3edb3
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 30, 2020
55f37fd
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 30, 2020
65dc905
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 30, 2020
ff661a9
Merge branch 'master' into api-review-endpoints_5733
6543 Apr 30, 2020
5af6fc5
Merge branch 'master' into api-review-endpoints_5733
6543 May 1, 2020
d1ae269
Update routers/api/v1/repo/pull_review.go
6543 May 1, 2020
e66b139
add comments
6543 May 1, 2020
42dfbe7
Merge branch 'master' into api-review-endpoints_5733
6543 May 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions modules/structs/pull_review.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright 2020 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package structs

import (
"time"
)

// PullRequestReview represents a pull request review
type PullRequestReview struct {
ID int64 `json:"id"`
PRURL string `json:"pull_request_url"`
Reviewer *User `json:"user"`
Body string `json:"body"`
CommitID string `json:"commit_id"`
Type string `json:"type"`
6543 marked this conversation as resolved.
Show resolved Hide resolved

// swagger:strfmt date-time
Created time.Time `json:"created_at"`
6543 marked this conversation as resolved.
Show resolved Hide resolved

// TODO: is there a way to get a URL to the review itself?
// HTMLURL string `json:"html_url"`
}

// PullRequestReviewComment represents a comment on a pull request
type PullRequestReviewComment struct {
ID int64 `json:"id"`
URL string `json:"url"`
PRURL string `json:"pull_request_url"`
ReviewID int64 `json:"pull_request_review_id"`
Path string `json:"path"`
CommitID string `json:"commit_id"`
DiffHunk string `json:"diff_hunk"`
LineNum uint64 `json:"position"`
OldLineNum uint64 `json:"original_position"`
Reviewer *User `json:"user"`
Body string `json:"body"`
}
10 changes: 9 additions & 1 deletion routers/api/v1/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ func RegisterRoutes(m *macaron.Macaron) {
bind := binding.Bind

if setting.API.EnableSwagger {
m.Get("/swagger", misc.Swagger) //Render V1 by default
m.Get("/swagger", misc.Swagger) // Render V1 by default
}

m.Group("/v1", func() {
Expand Down Expand Up @@ -794,6 +794,14 @@ func RegisterRoutes(m *macaron.Macaron) {
Patch(reqToken(), reqRepoWriter(models.UnitTypePullRequests), bind(api.EditPullRequestOption{}), repo.EditPullRequest)
m.Combo("/merge").Get(repo.IsPullRequestMerged).
Post(reqToken(), mustNotBeArchived, bind(auth.MergePullRequestForm{}), repo.MergePullRequest)
m.Group("/reviews", func() {
m.Combo("").Get(repo.ListPullReviews)
m.Group("/:id", func() {
m.Combo("").Get(repo.GetPullReview)
m.Combo("/comments").Get(repo.GetPullReviewComments)
})
})

})
}, mustAllowPulls, reqRepoReader(models.UnitTypeCode), context.ReferencesGitRepo(false))
m.Group("/statuses", func() {
Expand Down
Loading