-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue sidebar menus having an infinite height #10239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10239 +/- ##
==========================================
- Coverage 43.68% 43.67% -0.02%
==========================================
Files 582 582
Lines 80048 80048
==========================================
- Hits 34966 34957 -9
- Misses 40747 40754 +7
- Partials 4335 4337 +2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Feb 11, 2020
jolheiser
approved these changes
Feb 11, 2020
Please send backport |
Already done ;). I forgot to set the title properly though! #10240 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/ui
Change the appearance of the Gitea UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial revert of #10216, yet still an attempt at fixing #10218. This PR sets the
max-height
property to a different selector so it fixes the assignee menu too.Before:

After:

I'm willing to create a backport for v1.11, as it is quite noticetable on my production instance! 😄