Webhooks triggered twice

[0x1793d1]

• Gitea version (or commit ref): 1.9.0
• Git version: 2.22.0
• Operating system: Debian Buster / Docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

Hi,

Since 1.9.0, webhooks are triggered twice when committing via the website.

[lunny]

It seems there is one PR fixed that.

[0x1793d1]

You mean #7684?, I saw this PR, but it doesn't seem to work for my case.

[lunny]

No, I mean #7516, but it seems it hasn't been fixed.

[zeripath]

So I think this is because we're now running commits through the git hooks - so the webhook actions in commit repo action might be no longer needed.

@0x1793d1 are you sure that the webhooks you receive are absolutely the same?

[0x1793d1]

@zeripath Yes, they are the same.

Result on try.gitea.io : https://webhook.site/#!/ad98b669-2775-45b5-a98e-164aed79aa48/01e88be5-81b8-4582-9cc9-f72ba6b3a8b3/1

[lunny]

It seems recent version fixed this. But I don't know which PR did that.

[lunny]

I can't reproduce this on one 1.9.0 gitea instance with drone 1.1.0.

[lunny]

@0x1793d1 could you check if you have two webhooks from the same ci server.

[0x1793d1]

@lunny I am using Drone as CI server, and it receive two hooks when I commit via the website. I can reproduce this bug with a dummy webhook on try.gitea.io:

[quantonganh]

I can't reproduce this on one 1.9.0 gitea instance with drone 1.1.0.

I can reproduce this on Gitea 1.9.0 with Drone 1.2.1.

@lunny Please notice that #7726 is a bit different from this: it happened when we merge a PR. #7702 happened when we commit via web interface.

[quantonganh]

So I think this is because we're now running commits through the git hooks - so the webhook actions in commit repo action might be no longer needed.

@zeripath You mean this? https://github.com/go-gitea/gitea/blob/master/modules/repofiles/action.go#L115

[zeripath]

Yeah that's my worry but I'm a busy at the moment to double check this.

[lunny]

I found this will occupy randomly in v1.9.0.

[sapk]

Looking at some logs, I can confirm that it add a task during post-receive call and a other one later after the post-receive ended.

[sapk]

I think that call to PushUpdate should not be call anymore on web edit like in CreateOrUpdateRepoFile:

gitea/modules/repofiles/update.go

Line 117 in 7ad6710

func CreateOrUpdateRepoFile(repo *models.Repository, doer *models.User, opts *UpdateRepoFileOptions) (*structs.FileResponse, error) {

since it is now call via post-receive:

gitea/routers/private/hook.go

Line 147 in 3563650

if err := repofiles.PushUpdate(repo, branch, models.PushUpdateOptions{

[sapk]

Deleting branch since to be triggered in double also but I am not sure for the second call path. -> It create a push and a delete event. I don't exactly know if it is the expected way.

[metal3d]

Is the "latest" docker image updated with that fix ? I updated image last friday (6 sept) and I still see that issue with Drone.
Thanks

[lafriks]

It should be, what kind of webhook was trigger for you twice?

[metaisfabien]

Is the "latest" docker image updated with that fix ? I updated image last friday (6 sept) and I still see that issue with Drone.
Thanks

For me gitea/gitea:last send twice gitea/gitea:1.10 send one time.

[adrianyorke]

I am seeing this behavior for 1.12.0+dev-161-gf6067a846/git version 2.20.1/Debian Buster/SQLite:

[zeripath]

@adrianyorke that looks different, that's duplicate notifications and I suspect you may have two Gitea post-receive hooks in your repository.

But please open a different issue if you don't

[adrianyorke]

Thanks for replying @zeripath. Apologies, I was a little embarrassed when I realized I had added a comment to a Closed issue. I really wasn't expecting a reply, especially "same day" so thank you. I will experiment more and report back. So far this is a "default installation" but let's see.

[john-kheir]

I can see this issue on 1.11.1 which supposed to be the last official release

root@ff1a92d193e9:~# ./gitea --version
Gitea version 1.11.1 built with GNU Make 4.1, go1.13.8 : bindata, sqlite, sqlite_unlock_notify

[lafriks]

I think similar issue was fixed and will be in 1.11.2

[nagos]

Same stuff on 1.12.0+dev-20-gca181100c

Git push send duplicate triggers.
Gitea + drone.

And on 1.11.3
But 1.10.6 work fine, withoud duplicates.

[adrianyorke]

This is a closed thread but for anyone turning up here, my problem went away after the first day or so. I didn't need to fix anything myself or change any config, the duplicate triggers just stopped happening. Gitea has been stable since.

[nagos]

This is a closed thread but for anyone turning up here, my problem went away after the first day or so. I didn't need to fix anything myself or change any config, the duplicate triggers just stopped happening. Gitea has been stable since.

You are right! Issue went away after i restarted gitea.
So my guess, when they add trigger during configuration, it got added twice. But after restart, it loads from configuration file correctly.