Can't create file via API

[strahe]

• Gitea version (or commit ref): 1.8.2
• Git version:
• Operating system: linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

always: Error: Unprocessable Entity

Screenshots

[nopjmp]

Looks like you need to supply a message via the error message for the commit

gitea/modules/structs/repo_file.go

Lines 8 to 28 in 43cf2f3

	// FileOptions options for all file APIs
	type FileOptions struct {
	// message (optional) for the commit of this file. if not supplied, a default message will be used
	Message string `json:"message" binding:"Required"`
	// branch (optional) to base this file from. if not given, the default branch is used
	BranchName string `json:"branch"`
	// new_branch (optional) will make a new branch from `branch` before creating the file
	NewBranchName string `json:"new_branch"`
	// `author` and `committer` are optional (if only one is given, it will be used for the other, otherwise the authenticated user will be used)
	Author Identity `json:"author"`
	Committer Identity `json:"committer"`
	}
	// CreateFileOptions options for creating files
	// Note: `author` and `committer` are optional (if only one is given, it will be used for the other, otherwise the authenticated user will be used)
	type CreateFileOptions struct {
	FileOptions
	// content must be base64 encoded
	// required: true
	Content string `json:"content"`
	}

[jolheiser]

The comment says it is optional and mentions a default message, however I could not find anything to support that in the code.
Currently the message has no default, so it is correctly bound as required

@richmahn Looks like the comments were added in 43cf2f3#diff-ec0f0f34b75aa5b40d1a7e55251a9c35
Thoughts?

[nopjmp]

the binding in the struct is "Required" so the json parser will return an error.

[richmahn]

@jolheiser Interesting. I know I brought in the comments from another part of the code and guess that wasn't caught. Will see if message can be optional and will removed the required flag.

[richmahn]

I'll work on fixing this.

[richmahn]

Fixed in PR #7324