-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention completion should complete with people outside the organisation #3443
Comments
In #3136 , I fetch people list from current org's Assignees. May be we should add an api to fetch any people to Mention? But Im not good at go lang. Can anyone help to implement this api? |
You can sort the list by relevance. First people in the Issue/PR, then Project members, then Organization members, then Globally. WDYT? EDIT: Forgot "participants" as first prio. |
Using participants as the first set can potentially save on AJAX-calls as well, since we already have the participant list loaded in the page ;) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
Hey everyone, Just started using Gitea a bit more, and wanted to reference my boss in a PR but couldn't. Needs to just copy the github functionality, let the user decide who they want to mention without restrictions. Cheers |
I cannot even mention someone when I am the owner. This is really a bug and needs fixing please. This means that owners cannot ever mention anyone who isn't an owner - even if they are in another team too! @harryxu Could you perhaps just change your code so that it includes all teams in the dropdown and make a quick PR? |
I think maybe we could have an option to allow mention any people on that site on app.ini or not. |
Looking at this again, assuming the system is not multi-tenant, then it should just work like Github, probably showing everyone, and proritizing based on... 1) The contexts participants (issue/PR), 2) Everyone in the Org (if applicable) and 3) everyone. I don't see any reason why it needs to be limited to teams in the first place - it's not a secret who the other users are |
This is also a problem in our company where we installed Gitea. |
I think we can do that according if the repository is a public one or a private one.
|
Adding on this, my team has people who review pull requests without exclusive access to the code, and it would be nice to mention anyone within the organization because I have people assigned as reviewers who only look at the code in the PR not in the whole repo. |
closes go-gitea#3443 regression from ab5f0b7 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3444 Reviewed-by: Otto <[email protected]> Co-authored-by: Shiny Nematoda <[email protected]> Co-committed-by: Shiny Nematoda <[email protected]> (cherry picked from commit a641ebf)
When mentioning someone, the mention completion only mentions people inside my own org (or only the owner, if I'm in a user repository). Thats probaly fine for private repos, but for public ones?
Ideally, it should autocomplete
a) everyone, if the current issue is in a public repo
b) only people with access to the repo, if its a private one. This would include team members of an organisation (I think actually everyone within an organisation who is in a team with read access + issuetracker/pr) and added members via settings (because user repos can also add members for collaboration).
\cc @harryxu
The text was updated successfully, but these errors were encountered: