Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea service panics when attempting to clone/pull #32367

Closed
eeyrjmr opened this issue Oct 29, 2024 · 2 comments · Fixed by #32368
Closed

Gitea service panics when attempting to clone/pull #32367

eeyrjmr opened this issue Oct 29, 2024 · 2 comments · Fixed by #32368
Labels
Milestone

Comments

@eeyrjmr
Copy link
Contributor

eeyrjmr commented Oct 29, 2024

Description

upon upgrading to gitea-1.22.3 (from 1.22.2) on windows, any clone/pull via git results in a 500 error. The WebUI "mostly" still functions but does slow down.
Closer examination of the logs shows a panic

2024/10/29 10:34:07 ...rs/common/errpage.go:26:RenderPanicErrorPage() [E] PANIC: runtime error: invalid memory address or nil pointer dereference

since this was a MINOR bump, the service was "downgraded" to 1.22.2.
gitea-1.22.3-windows-4.0-amd64.exe and gitea-1.22.3-gogit-windows-4.0-amd64.exe were both tried and both exhibit the same issue

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://gist.github.com/eeyrjmr/a4eb1e5e159a71fc6152210fb030f2c3

Screenshots

No response

Git Version

2.46.1

Operating System

Windows

How are you running Gitea?

Windows service

Database

MySQL/MariaDB

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 29, 2024

/source/services/auth/source/oauth2/token.go:45 (0x200bbce)
/source/services/auth/source/oauth2/token.go:44 (0x200baad)
/source/services/auth/oauth2.go:34 (0x203940d)
/source/services/auth/basic.go:80 (0x2037264)

Regression of Don't init singing keys if oauth2 provider disabled (#32177)

@eeyrjmr
Copy link
Contributor Author

eeyrjmr commented Oct 29, 2024

I can confirm that Oauth is disabled.
This was done for an odd issue and I meant to raise a PR on that but I honestly forgot

The issue was a RESTRICTED user would have a js overlay about Oauth if it was enabled. This might have been fixed so I can recheck and if it is still an issue open a separate PR

wxiaoguang added a commit that referenced this issue Nov 12, 2024
Fix #32367

---------

Co-authored-by: Giteabot <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants