Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git lfs mirror download request maybe shouldn't carry Accept #31185

Closed
Zoupers opened this issue May 30, 2024 · 0 comments · Fixed by #31201
Closed

git lfs mirror download request maybe shouldn't carry Accept #31185

Zoupers opened this issue May 30, 2024 · 0 comments · Fixed by #31201
Labels
topic/lfs type/bug

Comments

@Zoupers
Copy link
Contributor

Zoupers commented May 30, 2024

Description

My situation is as follows: I use Gitea to mirror a repository on Bitbucket. Then, I found that the content stored using LFS (Large File Storage) was not correctly synchronized. So, I opened the trace logs to check. The batch operation was normal, but when it came to the download operation, the first server directly returned a 500 error, and no response body was returned. Therefore, I tried to understand what was happening from the source code and found that the request header for the download operation would additionally include an Accept field. When I removed it, the download worked properly...

Followed by the official doc, it seems there is no need to download with Accept header, maybe we can remove it from download?

I don't have the permission to the bitbucket server, so I don't know what happend in the bitbucket background.

Gitea Version

v1.22.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

linux

How are you running Gitea?

run from docker

Database

None
Zoupers added a commit to Zoupers/gitea that referenced this issue May 31, 2024
@Zoupers
Fix go-gitea#31185 try fix lfs download from bitbucket failed
9f95db6
@Zoupers Zoupers mentioned this issue May 31, 2024
Merged
silverwind pushed a commit that referenced this issue Jun 11, 2024
@Zoupers
Fix #31185 try fix lfs download from bitbucket failed (#31201)
e25d696 
Fix #31185
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 11, 2024
@Zoupers @GiteaBot
Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-git…
d05f20e 
…ea#31201)

Fix go-gitea#31185
@GiteaBot GiteaBot mentioned this issue Jun 11, 2024
Merged
lafriks pushed a commit that referenced this issue Jun 11, 2024
@GiteaBot @Zoupers
Fix #31185 try fix lfs download from bitbucket failed (#31201) (#31329)
758f84f 
Backport #31201 by @Zoupers

Fix #31185

Co-authored-by: Zoupers Zou <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this issue Jun 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
66bf728 
* giteaofficial/main:
  Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201)
  Enable `unparam` linter (go-gitea#31277)
  Make template `Iif` exactly match `if` (go-gitea#31322)
  update nix flake and add gofumpt (go-gitea#31320)
  code optimization (go-gitea#31315)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@Zoupers @earl-warren
Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-git…
8e8a07c 
…ea#31201)

Fix go-gitea#31185

(cherry picked from commit e25d696)
(cherry picked from commit baad833)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/lfs type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #31185 try fix lfs download from bitbucket failed Zoupers/gitea
2 participants
@lunny @Zoupers