Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More UI Errors #27173

Closed
C-EO opened this issue Sep 21, 2023 · 3 comments · Fixed by #27175
Closed

More UI Errors #27173

C-EO opened this issue Sep 21, 2023 · 3 comments · Fixed by #27175
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@C-EO
Copy link

C-EO commented Sep 21, 2023

Description

Currently, I'm finding very many UI errors on Gitea. Most of them are padding. A few are with non-working buttons.

Screenshots

Why are the arrows not in line with the words? It's weird to have them slightly above the words. ->
image

image

Padding. ->
image

Wording needs more centering in some buttons. ->
image

Non-working buttons. (For now only on 500 page) ->
image

Gitea Version

1.22.0+dev-3-ge46274b5b

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

linux 6.2.0-1013-gcp

Browser Version

Microsoft Edge 117.0.2045.31 (Official build) (64-bit)

@C-EO C-EO added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 21, 2023
@wxiaoguang
Copy link
Contributor

Why are the arrows not in line with the words? It's weird to have them slightly above the words. ->
Padding. ->

-> Fix dropdown icon position #27175

Wording needs more centering in some buttons. ->

It is centered.

Non-working buttons. (For now only on 500 page) ->

The 500 page doesn't have the ability render user-related menu. So that "icon" is just to make the UI look "balanced", it is a fake button.

@silverwind
Copy link
Member

The 500 page doesn't have the ability render user-related menu. So that "icon" is just to make the UI look "balanced", it is a fake button.

We should adapt the styling of the button to be inline with the current button that has no border or background. Ideally I'd like this non-function button to be removed, though.

@wxiaoguang
Copy link
Contributor

I am neutral for changing/keeping/removing the fake button, either is fine, since the 500 page is not a real user page and shouldn't appear in daily usage.

wxiaoguang added a commit that referenced this issue Sep 21, 2023
According to https://fomantic-ui.com/modules/dropdown.html and our
"devtest" page, many dropdown elements has incorrect "icon" position.

This PR fixes all of them. Fix #27173
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 21, 2023
According to https://fomantic-ui.com/modules/dropdown.html and our
"devtest" page, many dropdown elements has incorrect "icon" position.

This PR fixes all of them. Fix go-gitea#27173
wxiaoguang added a commit that referenced this issue Sep 21, 2023
Backport #27175 by @wxiaoguang

According to https://fomantic-ui.com/modules/dropdown.html and our
"devtest" page, many dropdown elements has incorrect "icon" position.

This PR fixes all of them. Fix #27173

Co-authored-by: wxiaoguang <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants