Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show More button remains in file-list after expanding #24938

Closed
kdumontnu opened this issue May 25, 2023 · 0 comments · Fixed by #24998
Closed

Show More button remains in file-list after expanding #24938

kdumontnu opened this issue May 25, 2023 · 0 comments · Fixed by #24998
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@kdumontnu
Copy link
Contributor

Description

The gitea "Show More" button will remain in the file-list after the files are full expanded. The button goes away in the list view, but doesn't appear to work for the file-list.

Gitea Version

1.19-1.20

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

https://gitea.com/Kyle/Tester/pulls/3/files

Database

None
@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 25, 2023
@sillyguodong sillyguodong mentioned this issue May 29, 2023
Closed
@wxiaoguang wxiaoguang mentioned this issue May 30, 2023
Merged
lunny pushed a commit that referenced this issue May 30, 2023
@wxiaoguang
Refactor diffFileInfo / DiffTreeStore (#24998)
ee99cf6 
Follow  #21012, #22399

Replace #24983, fix #24938

Help #24956

Now, the `window.config.pageData.diffFileInfo` itself is a reactive
store, so it's quite easy to sync values/states by it, no need to do
"doLoadMoreFiles" or "callback".

Screenshot: these two buttons both work. After complete loading, the UI
is also right.

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/cc6310fd-7f27-45ea-ab4f-24952a87b421)


![image](https://github.com/go-gitea/gitea/assets/2114189/4c11dd67-ac03-4568-8541-91204d27a4e3)


![image](https://github.com/go-gitea/gitea/assets/2114189/38a22cec-41be-41e6-a209-f347b7a4c1de)

</details>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
2 participants
@silverwind @kdumontnu