Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing tags - ERROR 404 #23865

Closed
BElluu opened this issue Apr 1, 2023 · 3 comments · Fixed by #23883
Closed

Editing tags - ERROR 404 #23865

BElluu opened this issue Apr 1, 2023 · 3 comments · Fixed by #23883
Labels

Comments

@BElluu
Copy link
Contributor

BElluu commented Apr 1, 2023

Description

If you try to edit the tag, you get a 404 error. The tag remains unchanged. I reproduce it on demo and my dev env.

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://gist.github.com/BElluu/cc571885fb7a232077f89760bbe60b6b

Screenshots

image

Git Version

development

Operating System

Linux

How are you running Gitea?

Using debuger or make command

Database

MySQL

@BElluu BElluu added the type/bug label Apr 1, 2023
@lunny
Copy link
Member

lunny commented Apr 2, 2023

I couldn't reproduce it in your try url.

@BElluu
Copy link
Contributor Author

BElluu commented Apr 2, 2023

@lunny I reproduce it all the time. I record screen video - look at this.

gitea_tag.mp4

@Zettat123
Copy link
Contributor

related code

if rel.IsTag {
ctx.NotFound("GetRelease", err)
return
}

jolheiser pushed a commit that referenced this issue Apr 3, 2023
Fixes #23865

In GitHub, users cannot edit a tag.

<img
src="https://user-images.githubusercontent.com/15528715/229409445-4233941b-3a37-4846-bc0c-efa94b90d9e0.png"
width="600px" />

So in this PR the edit button will not be shown if the release's `IsTag`
is `true`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants