Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'length') (https://xxx.xx/assets/js/index.js?v=1.20.0~dev-240-gd4f35bd681 @ 37:60918). Open browser console to see more details. #23657

Closed
hiifong opened this issue Mar 23, 2023 · 3 comments · Fixed by #23660
Closed

JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'length') (https://xxx.xx/assets/js/index.js?v=1.20.0~dev-240-gd4f35bd681 @ 37:60918). Open browser console to see more details. #23657

hiifong opened this issue Mar 23, 2023 · 3 comments · Fixed by #23660
Labels
type/bug

Comments

@hiifong
Copy link
Member

hiifong commented Mar 23, 2023 •
edited
Loading

Description

When i click on the authenticate ssh button, this js error is thrown

I can reproduce the bug on the gitea.com and try.gitea.io

Gitea Version

v1.20+

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image
image

Git Version

No response

Operating System

No response

How are you running Gitea?

./gitea web

Database

None
@wxiaoguang
Copy link
Contributor

Incorrect copy-paste code by #17743 , and it triggers a bug.

@wxiaoguang wxiaoguang mentioned this issue Mar 23, 2023
Merged
@wxiaoguang
Copy link
Contributor

Will be fixed by #23660

@hiifong
Copy link
Member Author

hiifong commented Mar 23, 2023

Will be fixed by #23660

Thank you

techknowlogick pushed a commit that referenced this issue Mar 23, 2023
@wxiaoguang
Fix incorrect show-modal and show-panel class (#23660)
378d6b8 
That's incorrect code caused by Copy&Paste.

`show-modal` / `show-panel` are used by JS to show something, but these
links have `href`, they should navigate to new page.

Close #23657
@wxiaoguang wxiaoguang mentioned this issue Mar 23, 2023
Merged
jolheiser pushed a commit that referenced this issue Mar 24, 2023
@wxiaoguang
Fix incorrect show-modal and show-panel class (#23660) (#23663)
780f71c 
Backport #23660

That's incorrect code caused by Copy&Paste.

`show-modal` / `show-panel` are used by JS to show something, but these
links have `href`, they should navigate to new page.

Close #23657
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect show-modal and show-panel class wxiaoguang/gitea
2 participants
@wxiaoguang @hiifong