Diff view of editor is broken #23265
Comments
|
Could you try 1.18.5? |
|
On try.gitea.io, it's also broken. ps: IMO, not "completely" broken, only partially broken 😂 the diff part still works, but the line number & hidden block don't work. Luckily, users could still see the diff. And yes, this is a regression bug and should be fixed.
|
|
"broken" does not accurately describe this issue. |
|
It has been broken for long time, not only one regression I guess. See Fix broken code editor diff preview #23307 |
lunny
pushed a commit
that referenced
this issue
Mar 6, 2023
Close #23265, the code editor diff preview has been broken for long time. * Fix the regression for `data-line-num` * `.code-diff` is necessary to show the line number * Fix the regression for #12434 * The diff: [12434](https://github.com/go-gitea/gitea/pull/12434/files?diff=unified&w=1) * It hides the Type(4) (aka HunkHeader) for unexpected cases. Diff with ignoring whitespaces: https://github.com/go-gitea/gitea/pull/23307/files?diff=unified&w=1 Before: see the issue #23265 After: 
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Mar 6, 2023
Close go-gitea#23265, the code editor diff preview has been broken for long time. * Fix the regression for `data-line-num` * `.code-diff` is necessary to show the line number * Fix the regression for go-gitea#12434 * The diff: [12434](https://github.com/go-gitea/gitea/pull/12434/files?diff=unified&w=1) * It hides the Type(4) (aka HunkHeader) for unexpected cases. Diff with ignoring whitespaces: https://github.com/go-gitea/gitea/pull/23307/files?diff=unified&w=1 Before: see the issue go-gitea#23265 After: 
jolheiser
pushed a commit
that referenced
this issue
Mar 6, 2023
Backport #23307 Close #23265, the code editor diff preview has been broken for long time. * Fix the regression for `data-line-num` * `.code-diff` is necessary to show the line number * Fix the regression for #12434 * The diff: [12434](https://github.com/go-gitea/gitea/pull/12434/files?diff=unified&w=1) * It hides the Type(4) (aka HunkHeader) for unexpected cases. Diff with ignoring whitespaces: https://github.com/go-gitea/gitea/pull/23307/files?diff=unified&w=1 Before: see the issue #23265 After:  Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
The diff of the built-in Editor is completely broken. It doesn't show the Line numbers and also doesn't show, when another part of the file starts.
Screenshots
The diff of the Editor:
The normal diff view after making the commit for comparison:
Gitea Version
1.18.3
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
Manjaro
Browser Version
Firefox 110
The text was updated successfully, but these errors were encountered: