When official review is deleted, previous review should become official #22406
Comments
|
Maybe we should disallow to delete an approval or reject review? |
I hope not. I use it in my workflow. We have a bot account that automatically submits approvals in some scenario's. |
jpraet
added a commit
to jpraet/gitea
that referenced
this issue
Jan 14, 2023
lafriks
added a commit
to jpraet/gitea
that referenced
this issue
Jan 15, 2023
lafriks
added a commit
that referenced
this issue
Jan 15, 2023
…22449) Fix #22406 Co-authored-by: Lauris BH <[email protected]>
jpraet
added a commit
to jpraet/gitea
that referenced
this issue
Jan 15, 2023
…o-gitea#22449) Fix go-gitea#22406 Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
As stated here, only reviewers latest review of type approve and reject shall count as "official". So when submitting a new "official" review, the "official" status of existing reviews of that user are cleared.
However, when deleting a review (currently only possible through the API), the "official" status of the previous approval/rejection of that user is never restored.
Gitea Version
1.18.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
None
The text was updated successfully, but these errors were encountered: