Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneccessary SMTP_ADDR lookup when using "PROTOCOL = sendmail" #22287

Closed
markshep opened this issue Dec 30, 2022 · 1 comment · Fixed by #22300
Closed

Unneccessary SMTP_ADDR lookup when using "PROTOCOL = sendmail" #22287

markshep opened this issue Dec 30, 2022 · 1 comment · Fixed by #22300
Labels
type/bug
Milestone
1.18.1

Comments

@markshep
Copy link

Description

I've just upgraded to 1.18.0 and had to fix my [mailer] config to avoid #22274 (and also update my [log] config just to see the problem in the first place!). Now that I can see warnings in the console I noticed this:

2022/12/30 21:49:49 ...es/setting/mailer.go:263:tryResolveAddr() [W] could not look up mailer.SMTP_ADDR: lookup : no such host

However it makes no sense for gitea to be attempting to resolve SMTP_ADDR as I'm using the "sendmail" PROTOCOL for my mailer:

[mailer]
ENABLED       = true
FROM          = Gitea <[email protected]>
PROTOCOL      = sendmail
SENDMAIL_PATH = /usr/sbin/sendmail
SENDMAIL_ARGS = --

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 11.6 (amd64)

How are you running Gitea?

Downloaded from your GitHub release page.

Database

None
@lunny lunny mentioned this issue Dec 31, 2022
Merged
@lunny
Copy link
Member

lunny commented Dec 31, 2022

22295 is a wrong ref.

@lunny lunny mentioned this issue Dec 31, 2022
Merged
@lunny lunny added this to the 1.18.1 milestone Dec 31, 2022
techknowlogick pushed a commit that referenced this issue Jan 9, 2023
@lunny
Don't lookup mail server when using sendmail (#22300)
99a675f 
Fix #22287
lunny added a commit to lunny/gitea that referenced this issue Jan 9, 2023
@lunny
Don't lookup mail server when using sendmail (go-gitea#22300)
ca15ac5 
Fix go-gitea#22287
@lunny lunny mentioned this issue Jan 9, 2023
Merged
techknowlogick pushed a commit that referenced this issue Jan 9, 2023
@lunny
Don't lookup mail server when using sendmail (#22300) (#22383)
32999e2 
Fix #22287
backport #22300
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.18.1
Development

Successfully merging a pull request may close this issue.

Don't lookup mail server when using sendmail lunny/gitea
2 participants
@lunny @markshep