Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date range in activity page is not localized #21380

Closed
emansije opened this issue Oct 8, 2022 · 1 comment · Fixed by #21410
Closed

Date range in activity page is not localized #21380

emansije opened this issue Oct 8, 2022 · 1 comment · Fixed by #21410
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@emansije
Copy link
Contributor

emansije commented Oct 8, 2022

Description

The date range on the top left of the activity board is not localized. It always shows up in English, independently of the chosen interface language. It affects every version that I've tested, including the development one:

https://try.gitea.io/emansije/teste/activity/yearly

Testing it is just a matter of selecting any localization while on the activity page.

Screenshots

activity

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Garuda Linux

Browser Version

Firefox 105.0.3 (64-bit)
@emansije emansije added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 8, 2022
@yardenshoham
Copy link
Member

I'll take this

This was referenced Oct 9, 2022
Closed
Merged
Merged
lafriks pushed a commit that referenced this issue Oct 12, 2022
@yardenshoham @silverwind
Respect user's locale when rendering the date range in the repo activ…
6a6dc97 
…ity page (#21410)

# Description
Previously, to make the date range understood by all, we used the format
"2006-01-02" for the dates as it's locale-generic.

This commit changes the rendering logic. Instead of rendering the date
on the server, we send a formatted computer-readable timestamp. The
client's javascript then renders it according to the user's locale.

This approach is reusable across the codebase, any `<time></time>` tag
with the data-format="date" attribute would get rendered according to
the user's chosen locale.

## Previous View

![image](https://user-images.githubusercontent.com/20454870/195099143-e1c5df86-282a-42f1-898f-a36bb5fe7c2f.png)

## New View

### English

![image](https://user-images.githubusercontent.com/20454870/195099301-5cda4eab-4012-49d5-97e5-b1f9cada9c06.png)

### French

![image](https://user-images.githubusercontent.com/20454870/195099434-ce23e394-8d65-4c4c-8ac8-8b96bc9044f3.png)

### Portuguese

![image](https://user-images.githubusercontent.com/20454870/195099559-9a7aed28-944a-45ec-bedb-64403e3faede.png)

### Italian

![image](https://user-images.githubusercontent.com/20454870/195099661-17758d55-3fe0-4797-879b-d45de0ee8ba3.png)

# References
* #21380 
* #21387
* #21396

Inspiration:

I think either differentiating by class, or probably better by a custom
attribute such as `data-format` or similar, is the best course of
action.

_Originally posted by @delvh in
#21396 (comment)
      


Resolves #21380

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
2 participants
@emansije @yardenshoham