Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization is null from GET team API #20399

Closed
arnWolff opened this issue Jul 18, 2022 · 0 comments · Fixed by #24694
Closed

Organization is null from GET team API #20399

arnWolff opened this issue Jul 18, 2022 · 0 comments · Fixed by #24694
Labels
modifies/api This PR adds API routes or modifies them type/bug

Comments

@arnWolff
Copy link

Description

When i call API endpoint /api/v1/teams/{id}, the organization property is null.
I would expect it to return Oraganization entity as value.
Same result if called from an Admin account or user member of this team.

Is this expected behaviour?

I cannot reproduce this issue on official website because i cannot create organization there.

Gitea Version

1.16.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Ubuntu Server 20.04

How are you running Gitea?

Running Gitea on local server.

Database

SQLite
@noerw noerw added the modifies/api This PR adds API routes or modifies them label Sep 15, 2022
@yardenshoham yardenshoham mentioned this issue May 13, 2023
Merged
silverwind pushed a commit that referenced this issue May 13, 2023
@yardenshoham @GiteaBot
Fix organization field being null in GET /api/v1/teams/{id} (#2…
542adf5 
…4694)

Enabled the organization loading flag.

- Fixes #20399 

# Before
```json
{
  ...
  "description": "",
  "organization": null,
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

# After
```json
{
  ...
  "description": "",
  "organization": {
    "id": 2,
    "name": "bigorg",
    "full_name": "",
    "avatar_url": "https://3000-yardenshoham-gitea-3gfrlc9gn4h.ws-us96b.gitpod.io/avatars/e2649b0c016d9102664a7d4349503eb9",
    "description": "",
    "website": "",
    "location": "",
    "visibility": "public",
    "repo_admin_change_team_access": true,
    "username": "bigorg"
  },
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this issue May 13, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this issue May 13, 2023
@yardenshoham @GiteaBot
Fix organization field being null in GET /api/v1/teams/{id} (go…
7ad2a4c 
…-gitea#24694)

Enabled the organization loading flag.

- Fixes go-gitea#20399 

# Before
```json
{
  ...
  "description": "",
  "organization": null,
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

# After
```json
{
  ...
  "description": "",
  "organization": {
    "id": 2,
    "name": "bigorg",
    "full_name": "",
    "avatar_url": "https://3000-yardenshoham-gitea-3gfrlc9gn4h.ws-us96b.gitpod.io/avatars/e2649b0c016d9102664a7d4349503eb9",
    "description": "",
    "website": "",
    "location": "",
    "visibility": "public",
    "repo_admin_change_team_access": true,
    "username": "bigorg"
  },
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Giteabot <[email protected]>
silverwind pushed a commit that referenced this issue May 13, 2023
@GiteaBot @yardenshoham
Fix organization field being null in GET /api/v1/teams/{id} (#2…
da1c38d 
…4694) (#24696)

Backport #24694 by @yardenshoham

Enabled the organization loading flag.

- Fixes #20399 

# Before
```json
{
  ...
  "description": "",
  "organization": null,
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

# After
```json
{
  ...
  "description": "",
  "organization": {
    "id": 2,
    "name": "bigorg",
    "full_name": "",
    "avatar_url": "https://3000-yardenshoham-gitea-3gfrlc9gn4h.ws-us96b.gitpod.io/avatars/e2649b0c016d9102664a7d4349503eb9",
    "description": "",
    "website": "",
    "location": "",
    "visibility": "public",
    "repo_admin_change_team_access": true,
    "username": "bigorg"
  },
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this issue Jun 3, 2023
@GiteaBot @earl-warren
Fix organization field being null in GET /api/v1/teams/{id} (go…
bfa368a 
…-gitea#24694) (go-gitea#24696)

Backport go-gitea#24694 by @yardenshoham

Enabled the organization loading flag.

- Fixes go-gitea#20399

# Before
```json
{
  ...
  "description": "",
  "organization": null,
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

# After
```json
{
  ...
  "description": "",
  "organization": {
    "id": 2,
    "name": "bigorg",
    "full_name": "",
    "avatar_url": "https://3000-yardenshoham-gitea-3gfrlc9gn4h.ws-us96b.gitpod.io/avatars/e2649b0c016d9102664a7d4349503eb9",
    "description": "",
    "website": "",
    "location": "",
    "visibility": "public",
    "repo_admin_change_team_access": true,
    "username": "bigorg"
  },
  "includes_all_repositories": true,
  "permission": "owner",
  ...
}
```

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
(cherry picked from commit da1c38d)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix organization field being null in GET /api/v1/teams/{id} yardenshoham/gitea
2 participants
@arnWolff @noerw