Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: PullReview is lacking an updated_at #19997

Closed
mheden opened this issue Jun 17, 2022 · 1 comment · Fixed by #21812
Closed

API: PullReview is lacking an updated_at #19997

mheden opened this issue Jun 17, 2022 · 1 comment · Fixed by #21812
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@mheden
Copy link

mheden commented Jun 17, 2022

Feature Description

In the API, the PullReview object does only have an creation date (submitted_at) but not an updated_at.

If a PullReview is started (PENDING) and the reviewer is delayed for some reason, the APPROVED the only time available is the time submitted but not when the state changed to APPROVED.

The webinterface seem to be able to extract this information somehow though, so maybe I'm using the wrong endpoint?

Screenshots

No response
@mheden mheden added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 17, 2022
@mheden
Copy link
Author

mheden commented Jun 17, 2022

It looks like the "updated" time is available in the database at least.

@lunny lunny added modifies/api This PR adds API routes or modifies them and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 17, 2022
@yardenshoham yardenshoham mentioned this issue Nov 14, 2022
Merged
lafriks pushed a commit that referenced this issue Nov 15, 2022
@yardenshoham @lunny
Add updated_at field to PullReview API object (#21812)
6c8ff32 
* Closes #19997

Adds an `updated_at` time field to the `PullReview` API object to
specify when the pull request review's state changed.

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
fsologureng pushed a commit to fsologureng/gitea that referenced this issue Nov 22, 2022
@yardenshoham @lunny @fsologureng
Add updated_at field to PullReview API object (go-gitea#21812)
4cf8c4c 
* Closes go-gitea#19997

Adds an `updated_at` time field to the `PullReview` API object to
specify when the pull request review's state changed.

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add updated_at field to PullReview API object yardenshoham/gitea
2 participants
@lunny @mheden