Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View dll file occupy template render error. #18231

Closed
lunny opened this issue Jan 11, 2022 · 1 comment · Fixed by #18234
Closed

View dll file occupy template render error. #18231

lunny opened this issue Jan 11, 2022 · 1 comment · Fixed by #18234
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Comments

@lunny
Copy link
Member

lunny commented Jan 11, 2022

Caused by #17562

2022/01/11 16:01:16 ...s/context/context.go:206:HTML() [E] Render failed: template: repo/unicode_escape_prompt:1:18: executing "repo/unicode_escape_prompt" at <.EscapeStatus.BadBIDI>: nil pointer evaluating interface {}.BadBIDI
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 11, 2022
@zeripath
Copy link
Contributor

It would be useful to see a test case if you have one.

zeripath added a commit to zeripath/gitea that referenced this issue Jan 11, 2022
@zeripath
Prevent NPE when viewing non-rendered files
2c2f483 
Fix go-gitea#18231

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Jan 11, 2022
Merged
6543 pushed a commit that referenced this issue Jan 11, 2022
@zeripath
Prevent NPE when viewing non-rendered files (#18234)
09d2029 
Fix #18231

Signed-off-by: Andrew Thornton <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath
Prevent NPE when viewing non-rendered files (go-gitea#18234)
9d4a3b3 
Fix go-gitea#18231

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent NPE when viewing non-rendered files zeripath/gitea
2 participants
@lunny @zeripath