Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] /repos/{owner}/{repo}/pulls/{index} returns false for all permissions of the base/head branch repo #17181

Closed
qwerty287 opened this issue Sep 29, 2021 · 1 comment · Fixed by #17214
Closed

[API] /repos/{owner}/{repo}/pulls/{index} returns false for all permissions of the base/head branch repo #17181

qwerty287 opened this issue Sep 29, 2021 · 1 comment · Fixed by #17214
Labels
modifies/api This PR adds API routes or modifies them type/bug
Milestone
1.15.4

Comments

@qwerty287
Copy link
Contributor

Gitea Version

(almost) latest main

Git Version

No response

Operating System

No response

How are you running Gitea?

Built from source, from cli

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

If I get a PR via the API, it returns the pull's head/base branch. The repos that are included in these information also return the permissions, but all values of these permissions (admin, push, pull) are false.

Screenshots

No response
@noerw
Copy link
Member

noerw commented Sep 29, 2021

can confirm with 1.14.7 and current main

@noerw noerw added modifies/api This PR adds API routes or modifies them type/bug labels Sep 29, 2021
@noerw noerw added this to the 1.15.4 milestone Sep 29, 2021
@pricly-yellow pricly-yellow mentioned this issue Oct 4, 2021
Merged
6543 added a commit that referenced this issue Oct 7, 2021
@pricly-yellow @delvh @6543
API pull's head/base have correct permission (#17214)
4afdb1e 
close #17181

* for all pull requests API return permissions of caller
* for all webhook return empty permissions

Signed-off-by: Danila Kryukov <[email protected]>
Co-authored-by: delvh <[email protected]>
Co-authored-by: 6543 <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Oct 15, 2021
@pricly-yellow @delvh @6543
API pull's head/base have correct permission (go-gitea#17214)
506ed68 
close go-gitea#17181

* for all pull requests API return permissions of caller
* for all webhook return empty permissions

Signed-off-by: Danila Kryukov <[email protected]>
Co-authored-by: delvh <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.15.4
Development

Successfully merging a pull request may close this issue.

API pull's head/base have correct permission pricly-yellow/gitea
2 participants
@noerw @qwerty287