-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copying code to clipboard omits empty lines in some files #16434
Comments
Also of note, in diff view it works fine and the newline is there. Also there is no empty <code class="code-inner">
</code> |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Aug 12, 2021
When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix go-gitea#16434 Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this issue
Aug 13, 2021
* Ensure empty lines are copiable and final new line too When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix #16434 * Add test and ensure spans closed Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Aug 14, 2021
Backport go-gitea#16678 When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix go-gitea#16434 Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this issue
Aug 15, 2021
Backport #16678 When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix #16434 Signed-off-by: Andrew Thornton <[email protected]>
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this issue
Aug 24, 2021
… (go-gitea#16692) Backport go-gitea#16678 When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix go-gitea#16434 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On some files like https://try.gitea.io/silverwind/symlink-test/src/branch/master/.drone.yml copying to clipboard via text selection omits emty lines in the copied content. The HTML of those empty lines does not render anything and I think we'd need to render a newline character for such empty lines so browser selection can properly pick it up. The issue does not show in all files and I think it's somehow caused by the yaml syntax highlighting.
On gitea (no newline character):
On github (with newline character):
The text was updated successfully, but these errors were encountered: