Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link to submodule in WebUI #15178

Open
2 of 6 tasks
steled opened this issue Mar 27, 2021 · 0 comments
Open
2 of 6 tasks

Wrong link to submodule in WebUI #15178

steled opened this issue Mar 27, 2021 · 0 comments

Comments

@steled
Copy link

steled commented Mar 27, 2021

  • Gitea version (or commit ref): 1.13.6
  • Git version: 2.20.1
  • Operating system:
$ uname -amrs
Linux control01 5.10.17-v7+ #1403 SMP Mon Feb 22 11:29:51 GMT 2021 armv7l GNU/Linux
$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
  • used gitea package: gitea-1.13.6-linux-arm-6
  • gitea usage: systemd
  • distribution: Raspbian 10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

Hi, I updated from version 1.12.6 to 1.13.6 and have the following problem now.
My gitea is configured for HTTPS and my submodule is added via SSH.
From the main repo the link to the submodule is only HTTP so I can't access
my submodule from the web UI. In version 1.12.6 this worked as expected.

See below some informations:

$ git config --file=.gitmodules -l
submodule.terraform.path=terraform
[email protected]:steled/terraform.git
submodule.terraform.update=rebase

The web gui is showing http://172.16.4.20/steled/terraform but should show https://172.16.4.20/steled/terraform

SSH_DOMAIN = %(DOMAIN)s
PROTOCOL = https
DOMAIN = ***.duckdns.org
HTTP_PORT = 443
ROOT_URL = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/

When I manually set SSH_DOMAIN to 172.16.4.20 the WebUI shows https://***.duckdns.org/steled/terraform and the clone link shows [email protected]:steled/terraform.git

Would be great if you can have a look at.

Thanks and best regards

Screenshots

gitea_submodule_link

zeripath added a commit to zeripath/gitea that referenced this issue Mar 27, 2021
Sometimes Gitea users would like submodules when displayed on the website to have
a different alias than what is normally inferred by gitea.

This PR provides a mechanism to configure this.

Fix go-gitea#15178

Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant