Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request 500 error after force push #12953

Closed
2 of 7 tasks
lakostin opened this issue Sep 27, 2020 · 1 comment · Fixed by #12981
Closed
2 of 7 tasks

Pull request 500 error after force push #12953

lakostin opened this issue Sep 27, 2020 · 1 comment · Fixed by #12981
Labels
type/bug

Comments

@lakostin
Copy link

lakostin commented Sep 27, 2020 •
edited by zeripath
Loading

  • Gitea version (or commit ref):
    1.13.0+dev-683-gb725c4ee5
  • Git version:
    2.26.2
  • Operating system:
    Alpine Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Pull request shows 500 error after commands:

$ git push
$ git rebase -i HEAD~4
$ git push -f

...

2020/09/27 00:44:21 ...m.io/xorm/core/db.go:286:afterProcess() [I] [SQL] SELECT max( id ) as id FROM "commit_status" WHERE (repo_id = $1) AND (sha = $2) GROUP BY context_hash ORDER BY max( id ) desc LIMI
T 10 [12 22d12e408a3dc3618f2149097fdb20c83fa9fb18] - 566.67µs
2020/09/27 00:44:21 ...les/context/panic.go:35:1() [E] PANIC:: runtime error: invalid memory address or nil pointer dereference
       /usr/local/go/src/runtime/panic.go:212 (0x455972)
       /usr/local/go/src/runtime/signal_unix.go:720 (0x4557f2)
       /usr/local/go/src/container/list/list.go:66 (0x147ff42)
       /go/src/code.gitea.io/gitea/models/issue_comment.go:659 (0x147ff46)
       /go/src/code.gitea.io/gitea/routers/repo/issue.go:1172 (0x1f39144)
       /usr/local/go/src/reflect/value.go:475 (0x4a4b06)
       /usr/local/go/src/reflect/value.go:336 (0x4a3ff8)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xd7f619)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xd7efea)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x15cd7e4)
       /go/src/code.gitea.io/gitea/modules/context/repo.go:811 (0x15cd7c9)
       /usr/local/go/src/reflect/value.go:475 (0x4a4b06)
       /usr/local/go/src/reflect/value.go:336 (0x4a3ff8)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xd7f619)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xd7efea)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x15cbe73)
       /go/src/code.gitea.io/gitea/modules/context/repo.go:593 (0x15cbe5c)
       /usr/local/go/src/reflect/value.go:475 (0x4a4b06)
       /usr/local/go/src/reflect/value.go:336 (0x4a3ff8)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xd7f619)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xd7efea)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x15c9694)
       /go/src/code.gitea.io/gitea/modules/context/panic.go:39 (0x15c9685)
       /usr/local/go/src/reflect/value.go:475 (0x4a4b06)
       /usr/local/go/src/reflect/value.go:336 (0x4a3ff8)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xd7f619)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xd7efea)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x157dfe4)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/session/session.go:192 (0x157dfcd)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:79 (0xd809b2)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xd7f334)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xd7f0d9)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0xd926c5)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/recovery.go:161 (0xd926b8)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:40 (0xd846f7)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xd7f334)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xd7f0d9)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0xd919c9)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:52 (0xd919b4)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:40 (0xd846f7)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xd7f334)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xd7f0d9)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xd80b3c)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:187 (0xd93910)
       /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:303 (0xd8d0a5)
        /go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/macaron.go:218 (0xd85a6d)
       /go/src/code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0x11f8d73)
       /usr/local/go/src/net/http/server.go:2042 (0x779f83)
       /usr/local/go/src/net/http/server.go:2843 (0x77d582)
       /usr/local/go/src/net/http/server.go:1925 (0x778d8c)
       /usr/local/go/src/runtime/asm_amd64.s:1374 (0x477aa0)
        
2020/09/27 00:44:21 ...m.io/xorm/core/db.go:286:afterProcess() [I] [SQL] SELECT count(*) FROM "notification" WHERE (user_id = $1) AND (status = $2) [2 1] - 759.483µs

Screenshots

Screenshot from 2020-09-27 10-56-43
@lunny lunny added the type/bug label Sep 28, 2020
@lunny
Copy link
Member

lunny commented Sep 28, 2020

The previous commits maybe missed if git gc runned when a force push. Maybe we should remove these comments when force push?

zeripath added a commit to zeripath/gitea that referenced this issue Sep 29, 2020
@zeripath
Always return a list from GetCommitsFromIDs
13fe079 
`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in go-gitea#12953

Fix go-gitea#12953

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Sep 29, 2020
Merged
zeripath added a commit that referenced this issue Sep 29, 2020
@zeripath
Always return a list from GetCommitsFromIDs (#12981)
fe79b13 
`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in #12953

Fix #12953

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always return a list from GetCommitsFromIDs zeripath/gitea
2 participants
@lunny @lakostin