Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Commit and Changed Files tab broken #10920

Closed
1 of 4 tasks
xoxys opened this issue Apr 1, 2020 · 6 comments
Closed
1 of 4 tasks

PR Commit and Changed Files tab broken #10920

xoxys opened this issue Apr 1, 2020 · 6 comments

Comments

@xoxys
Copy link
Contributor

xoxys commented Apr 1, 2020 •
edited
Loading

  • Gitea version (or commit ref): 1.11.4
  • Operating system: CentOS 7
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite

Description

After upgrading to v1.11.3 the tabs for Commits and Changed Files are no longer accessible after a PR was merged.

Screenshot

grafik
@zeripath
Copy link
Contributor

zeripath commented Apr 1, 2020

Hi we've already fixed this with PR #10909. See #10766

There will be a migration that fixes these and other older problems in 1.12 - the code is in #10786

@zeripath zeripath closed this as completed Apr 1, 2020
@zeripath
Copy link
Contributor

zeripath commented Apr 1, 2020 •
edited
Loading

Please upgrade to 1.11.4 where the issue is fixed.

@xoxys
Copy link
Contributor Author

xoxys commented Apr 1, 2020

@zeripath I am already on 1.11.4 as written in my first post and it is still broken for an existing PR as you could see in the screenshot

@xoxys
Copy link
Contributor Author

xoxys commented Apr 1, 2020

Ok, it's fixed for new PR's but old broken PR's stay broken currently, right?

@zeripath
Copy link
Contributor

zeripath commented Apr 1, 2020

Yup sorry about that they'll get fixed when the migrations in 1.12 run but you can manually fix.

@xoxys
Copy link
Contributor Author

xoxys commented Apr 1, 2020

No worries. I've just misunderstood that point 🙂

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
zeripath added a commit to zeripath/gitea that referenced this issue Mar 7, 2022
@zeripath
Ensure isSSH is set whenever DISABLE_HTTP_GIT is set
99dafa8 
In clone_buttons.tmpl the defer block sets the javascript isSSH variable.
When DISABLE_HTTP_GIT is set we should always set this to true.

Fix go-gitea#10920

Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeripath @xoxys