Skip to content

Commit

Permalink
Add -F to commit search to treat keywords as strings (#28744) (#28748)
Browse files Browse the repository at this point in the history
Backport #28744 by @me-heer

Fixes #28269

The [default
behavior](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp)
of --grep in git log is to interpret the keyword as a regular
expression. This causes the search to fail in the cases where the search
keyword contains a `[`, since `[` is a special character used in grep.

If we want our keywords to be interpreted as 'strings', we should use
[-F
flag](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp).

Co-authored-by: Mihir Joshi <[email protected]>
  • Loading branch information
GiteaBot and me-heer authored Jan 10, 2024
1 parent bce27d0 commit f220f42
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions modules/git/repo_commit.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ func (repo *Repository) searchCommits(id SHA1, opts SearchCommitsOptions) ([]*Co
cmd.AddArguments("--all")
}

// interpret search string keywords as string instead of regex
cmd.AddArguments("-F")

// add remaining keywords from search string
// note this is done only for command created above
if len(opts.Keywords) > 0 {
Expand Down

0 comments on commit f220f42

Please sign in to comment.