Skip to content

Commit

Permalink
Set "type=button" for editor's toolbar buttons (#26510)
Browse files Browse the repository at this point in the history
The editor usually is in a form, so the buttons should have
"type=button", avoid conflicting with the form's submit.
  • Loading branch information
wxiaoguang authored Aug 15, 2023
1 parent e9d631e commit d317c98
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions web_src/js/features/comp/ComboMarkdownEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ class ComboMarkdownEditor {
for (const el of this.textareaMarkdownToolbar.querySelectorAll('.markdown-toolbar-button')) {
// upstream bug: The role code is never executed in base MarkdownButtonElement https://github.com/github/markdown-toolbar-element/issues/70
el.setAttribute('role', 'button');
// the editor usually is in a form, so the buttons should have "type=button", avoiding conflicting with the form's submit.
if (el.nodeName === 'BUTTON' && !el.getAttribute('type')) el.setAttribute('type', 'button');
}

const monospaceButton = this.container.querySelector('.markdown-switch-monospace');
Expand Down

0 comments on commit d317c98

Please sign in to comment.