Fix bug of DisableGravatar default value (#22296)

#18058 made a mistake. The disableGravatar's default value depends on `OfflineMode`. If it's `true`, then `disableGravatar` is true, otherwise it's `false`. But not opposite. Co-authored-by: KN4CK3R <[email protected]>
go-gitea · Jan 1, 2023 · 9c8fc7f · 9c8fc7f
1 parent 2bbf9e7
commit 9c8fc7f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/models/system/setting.go b/models/system/setting.go
@@ -266,7 +266,7 @@ func Init() error {
 		enableFederatedAvatar = false
 	}
 
-	if disableGravatar || !enableFederatedAvatar {
+	if enableFederatedAvatar || !disableGravatar {
 		var err error
 		GravatarSourceURL, err = url.Parse(setting.GravatarSource)
 		if err != nil {

diff --git a/modules/setting/picture.go b/modules/setting/picture.go
@@ -68,7 +68,7 @@ func newPictureService() {
 }
 
 func GetDefaultDisableGravatar() bool {
-	return !OfflineMode
+	return OfflineMode
 }
 
 func GetDefaultEnableFederatedAvatar(disableGravatar bool) bool {