Issue comment reactions should also check pull type (#13349)

* Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <[email protected]> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <[email protected]> * And there is another one ... Signed-off-by: Andrew Thornton <[email protected]>
go-gitea · Oct 29, 2020 · 55801cf · 55801cf
1 parent 4b33afc
commit 55801cf
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/routers/api/v1/repo/issue_reaction.go b/routers/api/v1/repo/issue_reaction.go
@@ -57,7 +57,11 @@ func GetIssueCommentReactions(ctx *context.APIContext) {
 		return
 	}
 
-	if !ctx.Repo.CanRead(models.UnitTypeIssues) {
+	if err := comment.LoadIssue(); err != nil {
+		ctx.Error(http.StatusInternalServerError, "comment.LoadIssue", err)
+	}
+
+	if !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull) {
 		ctx.Error(http.StatusForbidden, "GetIssueCommentReactions", errors.New("no permission to get reactions"))
 		return
 	}