Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a fixed width for "sl" column when parsing /proc/net/tcp lines #3660

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

michaelmerg
Copy link
Contributor

If /proc/net/tcp contains a large number of entries (>9999), parsing lines with len(sl) > 4 fails with the fixed width pattern. In that case the lines are silently ignored.

If /proc/net/tcp contains a large number of entries (>9999), parsing lines with len(sl) > 4 fails with the fixed width pattern. In that case the lines are silently ignored.
@michaelmerg michaelmerg changed the title Don't use a fixed width for s when parsing /proc/net/tcp lines Don't use a fixed width for "sl" column when parsing /proc/net/tcp lines Feb 13, 2024
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 19004d9 into go-delve:master Feb 13, 2024
2 checks passed
@michaelmerg michaelmerg deleted the patch-1 branch February 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants