Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make.go: skip codesigning when testing an existing build #3639

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ardnew
Copy link
Contributor

@ardnew ardnew commented Jan 17, 2024

When running make to re-test an existing build, the test target fails with the following error (on macOS):

$ make
Testing default backend
=== RUN   TestBuild
    dlv_test.go:92: makefile error: exit status 1
        output go build -ldflags "-extldflags -static" -tags=macnative "-ldflags=-s -X main.Build=88380654feb85c213d2bb60532d95be8d562c86e" github.com/go-delve/delve/cmd/dlv
        codesign -s dlv-cert ./dlv
        ./dlv: is already signed
        exit status 1

This PR adds a check to _scripts/make.go to simply skip the codesigning step if the codesign --verify command reports the executable is already signed with a valid certificate.

Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekparker derekparker merged commit dab870b into go-delve:master Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants