Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: reupgrade linux/386 builder to Go 1.21 #3560

Merged
merged 1 commit into from
Nov 9, 2023
Merged

TeamCity: reupgrade linux/386 builder to Go 1.21 #3560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .teamcity/settings.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ val targets = arrayOf(
"linux/amd64/1.21",
"linux/amd64/tip",

"linux/386/1.20",
"linux/386/1.21",

"linux/arm64/1.21",
"linux/arm64/tip",
Expand Down
3 changes: 2 additions & 1 deletion Documentation/backend_test_health.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Tests skipped by each supported backend:

* 386 skipped = 6
* 386 skipped = 7
* 1 broken
* 3 broken - cgo stacktraces
* 3 not implemented
* arm64 skipped = 1
Expand Down
2 changes: 1 addition & 1 deletion pkg/proc/proc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4683,8 +4683,8 @@ func TestCgoStacktrace2(t *testing.T) {
if !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
skipOn(t, "upstream issue", "windows")
skipOn(t, "broken", "arm64")
skipOn(t, "broken", "386")
}
skipOn(t, "broken", "386")
skipOn(t, "broken - cgo stacktraces", "darwin", "arm64")
skipOn(t, "broken", "ppc64le")
protest.MustHaveCgo(t)
Expand Down
6 changes: 3 additions & 3 deletions service/dap/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@ func TestFunctionNameFormattingInStackTrace(t *testing.T) {
[]onBreakpoint{{
// Stop at line 36
execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1)
client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t)
Expand Down Expand Up @@ -2463,7 +2463,7 @@ func TestGlobalScopeAndVariables(t *testing.T) {
[]onBreakpoint{{
// Stop at line 36
execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1)
client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t)
Expand Down Expand Up @@ -2538,7 +2538,7 @@ func TestRegistersScopeAndVariables(t *testing.T) {
[]onBreakpoint{{
// Stop at line 36
execute: func() {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) {
if runtime.GOARCH == "386" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 18) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 21) {
client.StepInRequest(1)
client.ExpectStepInResponse(t)
client.ExpectStoppedEvent(t)
Expand Down