Enable function call injection in Delve for linux/ppc64le #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
reviewed
Jul 31, 2023
|
See test failures. |
aarzilli
reviewed
Aug 2, 2023
aarzilli
reviewed
Aug 3, 2023
aarzilli
reviewed
Aug 7, 2023
derekparker
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
LGTM
Just waiting on https://go-review.googlesource.com/c/go/+/512575 to merge first to ensure we don't have to fix anything up after the fact.
There are a few other complications with testing this:
|
|
@archanaravindar can you fix the rebase conflicts and then we can merge? |
… decoding for floating point registers to make floatsum test work
…p_test_health.md file accordingly
archanaravindar
force-pushed
the
assgn2
branch
from
a8d2c16 to
d91bb95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the function call injection feature to be enabled in Go runtime for linux/ppc64le, delve can also make use of this feature on linux/ppc64le
The CL in gerrit which has been opened is as below
https://go-review.googlesource.com/c/go/+/512575
The debug call function tests dont work on PIE mode as a result they are skipped. Another PR will address this.