service/dap: fix test for debug in progress #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression attempted to match for a network address, but actually does not match any network addresses. The two documentation includes "192.0.2.1:25" and "[2001:db8::1]:80" as examples, neither of which match the current regex. This change updates the regular expression to ensure that there is some text at the desired position, but not what the text is.
|
Will merge after conflicts addressed. |
|
@suzmue can you take a look at the merge conflicts? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression attempted to match for a network address, but actually does not match any network addresses. The two documentation includes "192.0.2.1:25" and "[2001:db8::1]:80" as examples, neither of which match the current regex. This change updates the regular expression to ensure that there is some text at the desired position, but not what the text is.