Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: fix links with trailing dots #3399

Merged
merged 1 commit into from
May 31, 2023

Conversation

andreimatei
Copy link
Contributor

@andreimatei andreimatei commented May 30, 2023

This patch fixes the generation for one broken link that had a triling
dot in it.

@aarzilli
Copy link
Member

This documentation is autogenerated from the contents of pkg/terminal/command.go. In this case the problem is with the conversion script (_script/gen-cli-docs.go which calls WriteMarkdown in pkg/terminal/docgen.go).

This patch fixes the generation for one broken link that had a triling
dot in it.
@andreimatei andreimatei changed the title docs: fix link docgen: fix links with trailing dots May 30, 2023
@andreimatei
Copy link
Contributor Author

Heh, I had noticed that the text in question was present in two places, but I assumed it had just been copy-pasted.

I've now done something to the generation script; PTAL.

Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 5c711f8 into go-delve:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants