Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal/logflags: Added SetLoggerFactory(LoggerFactory) #3257

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

blaubaer
Copy link
Contributor

This change will enable people who want to embed Delve into their applications to adjust the logging better to their needs.

This change will enable people who want to embed Delve into their applications to adjust the logging better to their needs.
@blaubaer
Copy link
Contributor Author

Does someone know why the test TestClientServer_FindLocationsAddr (in this run) is failing? I cannot see a reason why it should fail (caused by my changes) nor I can bring it to fail locally. Is this a temporary issue?

@blaubaer blaubaer marked this pull request as ready for review January 25, 2023 14:26
@aarzilli
Copy link
Member

Does someone know why the test TestClientServer_FindLocationsAddr (in this run) is failing? I cannot see a reason why it should fail (caused by my changes) nor I can bring it to fail locally. Is this a temporary issue?

The windows/arm64 port has some problems.

pkg/logflags/logflags.go Show resolved Hide resolved
pkg/logflags/logflags.go Outdated Show resolved Hide resolved
pkg/logflags/logflags.go Outdated Show resolved Hide resolved
pkg/logflags/logflags.go Outdated Show resolved Hide resolved
pkg/logflags/logger.go Outdated Show resolved Hide resolved
@blaubaer blaubaer requested a review from aarzilli January 26, 2023 10:38
pkg/logflags/logger.go Outdated Show resolved Hide resolved
@blaubaer blaubaer requested a review from aarzilli January 31, 2023 17:14
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 260229b into go-delve:master Feb 14, 2023
@blaubaer blaubaer deleted the customizable-logging branch February 14, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants