service/dap: add panic and throw text to stopped event #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example for deadlock:
|
We can add more information to the stopped events on errors using the `Text` field in the stopped event. We already use this to display the runtime errors. Adding this information to the stopped reason will also help to show the user additional info when a stopped event is not associated with a particular goroutine.
aarzilli
reviewed
Jul 1, 2021
derekparker
requested changes
Jul 2, 2021
There was a problem hiding this comment.
Blocking this from merge until #2563 is pulled in and this is rebased.
This branch has been rebased. |
polinasok
reviewed
Jul 8, 2021
service/dap/server.go
Outdated
| body.Description, err = s.throwReason(goroutineID) | ||
| if err != nil { | ||
| body.Description = fmt.Sprintf("Error getting throw reason: %s", err.Error()) | ||
| // This is not currently working for Go 1.16 or 1.17: https://github.com/golang/go/issues/46425. |
There was a problem hiding this comment.
This issue was closed 7 days ago.
There was a problem hiding this comment.
Removed comment about 1.17
polinasok
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can add more information to the stopped events on errors using
the
Textfield in the stopped event. We already use this to displaythe runtime errors. Adding this information to the stopped reason will
also help to show the user additional info when a stopped event is not
associated with a particular goroutine.