Skip to content

Commit

Permalink
CI: update staticcheck version (#3533)
Browse files Browse the repository at this point in the history
Update staticcheck version and re-enable TestStaticcheck on Go 1.22.
  • Loading branch information
aarzilli authored Oct 20, 2023
1 parent 909add7 commit 90a1571
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion _scripts/test_linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export GOPATH
export PATH=$PATH:$GOROOT/bin:$GOPATH/bin
go version
if [ "$arch" != "ppc64le" ]; then
go install honnef.co/go/tools/cmd/[email protected] || true
go install honnef.co/go/tools/cmd/[email protected].6 || true
fi

uname -a
Expand Down
3 changes: 0 additions & 3 deletions cmd/dlv/dlv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1310,9 +1310,6 @@ func TestStaticcheck(t *testing.T) {
if err != nil {
t.Skip("staticcheck not installed")
}
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 22) {
t.Skip("broken with [email protected]")
}
// default checks minus SA1019 which complains about deprecated identifiers, which change between versions of Go.
args := []string{"-tests=false", "-checks=all,-SA1019,-ST1000,-ST1003,-ST1016,-S1021,-ST1023", "github.com/go-delve/delve/..."}
// * SA1019 is disabled because new deprecations get added on every version
Expand Down

0 comments on commit 90a1571

Please sign in to comment.