Skip to content

Commit

Permalink
proc: disable "wait-for" tests on freebsd (#3482)
Browse files Browse the repository at this point in the history
They are flaky in CI, I can not reproduce the problem locally.
  • Loading branch information
aarzilli authored Aug 23, 2023
1 parent 908876d commit 80e6c28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Documentation/backend_test_health.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ Tests skipped by each supported backend:
* 2 broken - cgo stacktraces
* darwin/lldb skipped = 1
* 1 upstream issue
* freebsd skipped = 4
* freebsd skipped = 6
* 2 flaky
* 4 not implemented
* linux/386/pie skipped = 1
* 1 broken
Expand Down
2 changes: 2 additions & 0 deletions pkg/proc/proc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6197,6 +6197,7 @@ func testWaitForSetup(t *testing.T, mu *sync.Mutex, started *bool) (*exec.Cmd, *

func TestWaitFor(t *testing.T) {
skipOn(t, "waitfor implementation is delegated to debugserver", "darwin")
skipOn(t, "flaky", "freebsd")

var mu sync.Mutex
started := false
Expand All @@ -6214,6 +6215,7 @@ func TestWaitFor(t *testing.T) {
}

func TestWaitForAttach(t *testing.T) {
skipOn(t, "flaky", "freebsd")
if testBackend == "lldb" && runtime.GOOS == "linux" {
bs, _ := ioutil.ReadFile("/proc/sys/kernel/yama/ptrace_scope")
if bs == nil || strings.TrimSpace(string(bs)) != "0" {
Expand Down

0 comments on commit 80e6c28

Please sign in to comment.