Ensure systemd-resolved binary is available at runtime #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdsimons
requested changes
Oct 24, 2022
obbardc
force-pushed
the
wip/obbardc/detect-systemd-resolved
branch
from
b82abb2 to
5aa9c08
Compare
obbardc
force-pushed
the
wip/obbardc/detect-systemd-resolved
branch
from
fb2de21 to
5aa9c08
Compare
Debian Unstable (and Fedora) have split systemd-resovled into a separate
package which enables systemd-resolved as the default name resolver at
install-time. Because of this, we cannot simply depend on systemd-resolved
in the distro packaging as this may cause the default name resolver to
change to systemd-resolved for some users.
If the user does not have system-resolved installed, fakemachine will
currently fails with any action which requires hostname resolution:
2022/09/19 10:49:09 ==== debootstrap ====
2022/09/19 10:49:09 Debootstrap | W: Unable to read /etc/apt/apt.conf.d/ - DirectoryExists (2: No such file or directory)
2022/09/19 10:49:09 Debootstrap | W: Unable to read /etc/apt/apt.conf.d/ - DirectoryExists (2: No such file or directory)
2022/09/19 10:49:09 Debootstrap | I: Target architecture can be executed
2022/09/19 10:49:09 Debootstrap | I: Retrieving InRelease
2022/09/19 10:49:09 Debootstrap | I: Retrieving Release
2022/09/19 10:49:09 Debootstrap | E: Failed getting release file http://deb.debian.org/debian/dists/stable/Release
2022/09/19 10:49:09 debootstrap.log | amd64: ok
2022/09/19 10:49:09 debootstrap.log | wget: unable to resolve host address 'deb.debian.org'
2022/09/19 10:49:09 debootstrap.log | wget: unable to resolve host address 'deb.debian.org'
Instead of forcing the user to install systemd-resolved, detect whether
the user has the binary installed and bubble up an error earlier if the
binary has not been found.
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020288
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020690
Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/detect-systemd-resolved
branch
from
5aa9c08 to
cfa6262
Compare
|
bors r+ |
|
Build succeeded: |
|
Fwiw the debian bugs; the right solution ther eis to update the Debian package with the dependency, these changes are more relevant for installations from source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian Unstable (and Fedora) has split systemd-resovled into a separate package which enables systemd-resolved as the default name resolver at install-time. Because of this, we cannot simply depend on systemd-resolved in the distro packaging as this may cause the default name resolver to change to systemd-resolved for some users.
If the user does not have system-resolved installed, fakemachine will currently fails with any action which requires hostname resolution:
Instead of forcing the user to install systemd-resolved, detect whether the user has the binary installed and bubble up an error earlier if the binary has not been found.
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020288
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020690
--
Requires go-debos/test-containers#14 to be merged first.