Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop timeout timers when no longer needed #803

Merged
merged 1 commit into from
Dec 11, 2024
Merged

stop timeout timers when no longer needed #803

merged 1 commit into from
Dec 11, 2024

Conversation

JohnRoesler
Copy link
Contributor

@JohnRoesler JohnRoesler commented Dec 11, 2024

What does this do?

Convert all uses of time.After to use time.NewTimer and then call Stop() if we don't hit the timer.

Which issue(s) does this PR fix/relate to?

resolves #802

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit 560a9dc into v2 Dec 11, 2024
4 checks passed
@JohnRoesler JohnRoesler deleted the timer-stop branch December 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - you have a lot of goroutine leaks
1 participant