Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup timers #776

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

hayotbisonai
Copy link
Contributor

@hayotbisonai hayotbisonai commented Sep 16, 2024

What does this do?

This PR adds cleanup logic to handle existing timers in the selectExecJobsOutForRescheduling function of the scheduler. By stopping and clearing old timers, it prevents memory leaks and ensures that jobs are rescheduled correctly without accumulating unused timers.

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

  • Added cleanup logic to stop and clear existing timers before setting a new timer.
  • Ensured that old timers are properly disposed of to avoid memory leaks.

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

  • The changes focus on improving memory management by ensuring that previous timers are stopped and cleared.
  • This update should help prevent potential memory leaks and ensure accurate job scheduling.

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 💯

@JohnRoesler JohnRoesler merged commit 40b8570 into go-co-op:v2 Sep 16, 2024
4 checks passed
rbroggi pushed a commit to rbroggi/gocron that referenced this pull request Sep 19, 2024
* fix: cleanup timers

* chore: bring comments back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants