Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-738: make withSeconds optional in cron-expression #739

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Jun 20, 2024

What does this do?

Which issue(s) does this PR fix/relate to?

Resolves #738

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit 9e83a13 into go-co-op:v2 Jun 20, 2024
4 checks passed
@rbroggi rbroggi deleted the issue-738-optional-seconds branch June 21, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - CronJob withSeconds documentation and implementation inconsistency
2 participants