Support redis lock automatic renewal #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Dec 15, 2023
redislock.go
Outdated
| @@ -24,30 +25,31 @@ var ( | |||
|
|
|||
| // NewRedisLocker provides an implementation of the Locker interface using | |||
| // redis for storage. | |||
| func NewRedisLocker(r redis.UniversalClient, options ...redsync.Option) (gocron.Locker, error) { | |||
| func NewRedisLocker(r redis.UniversalClient, autoExtendDuration time.Duration, options ...redsync.Option) (gocron.Locker, error) { | |||
There was a problem hiding this comment.
this is a breaking change (so let's not do it this way). An oversight on my part to have the options be ...resync.Option instead of a gocron.RedisLockerOption, to which we could just add WithAutoExtendDuration.
Instead, let's do it the way it should have been:
- Add a new method
func NewRedisLockerWithOptions(r redis.UniversalClient, options ...LockerOption) (gocron.Locker, error) - Define the LockerOption as
type LockerOption func(*redisLocker) error - Then, we could define all the options, with
Optionappended to the name so they are unique, as LockerOption type - Then, also add
WithAutoExtendDurationas an Option and implement it through there.
Let me know if you would like to complete this work. If not, I will take it on when I have time.
There was a problem hiding this comment.
I made some changes:
- Add
LockOption, supportWithAutoExtendDuration,WithRedsyncOptionsto be compatible with redsync options - Added
NewRedisLockerWithOptions - Modified
TestAutoExtend
Please review it again.
JohnRoesler
reviewed
Dec 18, 2023
JohnRoesler
reviewed
Dec 18, 2023
JohnRoesler
approved these changes
Dec 18, 2023
JohnRoesler
reviewed
Dec 18, 2023
JohnRoesler
reviewed
Dec 18, 2023
JohnRoesler
approved these changes
Dec 18, 2023
|
Can you create a new tag? @JohnRoesler |
|
Hi @JohnRoesler, sorry to bother, why this pr doesn't apply to the latest v2? |
|
@Sora233 it was added after I started the v2 branch. Feel free to make the same PR to the v2 branch - i will approve 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Support redis lock automatic renewal
Which issue(s) does this PR fix/relate to?
#54
List any changes that modify/break current functionality
Have you included tests for your changes?
TestAutoExtendDid you document any new/modified functionality?
example_test.goREADME.mdNotes