Adding validation for NewGormLocker and adding an extra option #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using suggestion Co-authored-by: John Roesler <[email protected]>
# Conflicts: # README.md # gormlock.go
|
@JohnRoesler shall we also validate that the table in which the cron job data is going to be stored also exists? |
|
@manuelarte yes that seems like a good safety thing to do |
added 2 commits
November 14, 2023 17:43
# Conflicts: # gorm_lock.go
JohnRoesler
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
Have you included tests for your changes?
There is a test to check that gorm.Db and worker can't be nil/empty
Did you document any new/modified functionality?
example_test.goREADME.mdNotes
The struct
CronJobLockhas defined thatworkercan't be nil, so it's a good practice to check that when creating the locker thatworkerfield is not empty. Same with*gorm.Db.I also created another option to just set a different precision, instead of the need to create the job identifier again.