Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectelv2: use baseURL from configuration #2291

Merged
merged 1 commit into from
Oct 4, 2024
Merged

selectelv2: use baseURL from configuration #2291

merged 1 commit into from
Oct 4, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 4, 2024

  • use config.BaseURL instead of the hardcoded one
  • use a more "standard" use agent

@ldez ldez requested a review from dmke October 4, 2024 16:18
@ldez ldez requested a review from dmke October 4, 2024 21:05
@dmke dmke mentioned this pull request Oct 4, 2024
Merged
@ldez ldez merged commit 85b5ef4 into go-acme:master Oct 4, 2024
4 checks passed
@ldez ldez deleted the fix/selectelv2-baseurl branch October 4, 2024 21:18
@ldez ldez added this to the v4.19 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/dnsprovider bug
Milestone
v4.19
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @dmke