Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53: minor correction to documentation #1916

Merged
merged 2 commits into from
May 17, 2023
Merged

route53: minor correction to documentation #1916

merged 2 commits into from
May 17, 2023

Conversation

vancluever
Copy link
Contributor

@vancluever vancluever commented May 17, 2023

Looks like the section that details the use of AWS_ASSUME_ROLE_ARN mentions that it can't be used in the configuration file, but it incorrectly repeats AWS_ASSUME_ROLE_ARN instead of mentioning AWS_ASSUME_ROLE_ARN_FILE.

Looks like the section that details the use of AWS_ASSUME_ROLE_ARN mentions that it can't be used in the configuration file, but it incorrectly repeats AWS_ASSUME_ROLE_ARN instead of mentioning AWS_ASSUME_ROLE_ARN_FILE.
@ldez ldez changed the title providers/dns/route53: minor correction to route53.toml route53: minor correction to documentation May 17, 2023
@ldez ldez added this to the v4.12 milestone May 17, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) May 17, 2023 16:22
@ldez ldez merged commit fc8e49b into go-acme:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants